tracing: remove asyncresource from kafka instrumentations #5703
Conversation
Overall package sizeSelf size: 9.46 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5703 +/- ##
=======================================
Coverage 79.41% 79.41%
=======================================
Files 520 520
Lines 23790 23804 +14
=======================================
+ Hits 18892 18905 +13
- Misses 4898 4899 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2025-05-28 14:11:35 Comparing candidate commit 56196e9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1274 metrics, 49 unstable metrics. |
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies Was this helpful? Give us feedback! |
Datadog ReportBranch report: ✅ 0 Failed, 1149 Passed, 0 Skipped, 15m 24.43s Total Time |
packages/datadog-instrumentations/src/confluentinc-kafka-javascript.js
Outdated
Show resolved
Hide resolved
packages/datadog-instrumentations/src/confluentinc-kafka-javascript.js
Outdated
Show resolved
Hide resolved
packages/datadog-instrumentations/src/confluentinc-kafka-javascript.js
Outdated
Show resolved
Hide resolved
packages/datadog-instrumentations/src/confluentinc-kafka-javascript.js
Outdated
Show resolved
Hide resolved
packages/datadog-instrumentations/src/confluentinc-kafka-javascript.js
Outdated
Show resolved
Hide resolved
packages/datadog-plugin-confluentinc-kafka-javascript/test/index.spec.js
Show resolved
Hide resolved
| @@ -11,7 +11,7 @@ const { TagKey } = require('../telemetry/iast-metric') | |||
|
|
|||
| class IastContextPlugin extends IastPlugin { | |||
| startCtxOn (channelName, tag) { | |||
| super.addSub(channelName, (message) => this.startContext()) | |||
| super.addSub(channelName, (message) => this.startContext(message?.currentStore)) | |||
There was a problem hiding this comment.
Just a thought as I'm not sure what is the best approach here, but using storage('legacy').run() in the subscriber would allow IAST to keep working the same way without any code change. I'm not sure how much this matters though as I think it shouldn't be using the tracing store anyway long term.
What does this PR do?
Removes use of
AsyncResourcefrom kafka plugins to support Node 24Motivation
Plugin Checklist
Additional Notes